No migration path for programmatically setting Push Notification credentials

[mymattcarroll]

trafficstars

Build/Submit details page URL

No response

Summary

Expo CLI contained a method for uploading Push Notification credentials programmatically for both Android and iOS.

Android

expo push:android:upload --api-key [KEY]

iOS

expo build:ios --push-id [ID] --push-p8-path [P8_Path]

The EAS CLI only supports an interactive way of setting these via:

eas credentials

Could the eas-cli package be updated into include commands such as:

eas credentials:android:push:upload --api-key [KEY]

eas credentials:ios:push:upload --push-id [ID] --push-p8-path [P8_Path]

Managed or bare?

Managed

Environment

N/A

Error output

No response

Reproducible demo or steps to reproduce from a blank project

N/A

[dsokal]

Hi, Could you please describe your use case? Usually, setting push credentials seems to be a one-time effort.

[mymattcarroll]

Hi @dsokal, thank you for the quick response.

As you expected, our use case is a little bit unusual. We are using Expo to generate a new app for each customer we bring on. We have automated the entire process using the Expo CLI and are now migrating to the EAS CLI so that we can update to SDK 47 when it comes out so that we can support iOS 16 ASAP.

https://blog.expo.dev/expo-sdk-46-c2a1655f63f7

This will be the final SDK with support for Classic Builds! SDK 47 will not support Classic Builds. This means that iOS 15 will be the last version that Classic Builds will target. If you want to target the iOS 16 SDK when it’s released, we suggest migrating to EAS Build sooner rather than later. See our original November 2021 announcement.

Are PRs welcome?

I have started looking at what would be involved in creating a PR for the following commands:

eas credentials:ios:push:upload --key-id [ID] --key-p8-path [P8_Path] --team-id [TEAM_ID] --team-name [OPTIONAL] --non-interactive

eas credentials:android:push:upload --api-key [KEY] --non-interactive

I believe I have worked out how to do it. The flags above seem to be the only configuration necessary to support a non-interactive way to upload push notification credentials.

I also thought of another approach using the credentials.json file if that is preferable.

Any guidance would be much appreciated.