expo-server-sdk-python icon indicating copy to clipboard operation
expo-server-sdk-python copied to clipboard

Add support for multiple recipient with one push message

Open mbordia-eightfold opened this issue 2 years ago • 1 comments

As per this example in expo documentation to attribute in PushMessage should expect string[] as well allowing support for multiple recipient for a push message.

There are few places in the codebase which results in the error when we pass list of expo tokens in to attribute:

  1. Expects to attribute to be string only
  2. Throws error even if response is expected response

I think proper implementation for this would either require : a. removal of the assumption that 1 push message corresponds to single recipient b. or converting single PushMessage into multiple duplicate PushMessages.

mbordia-eightfold avatar Dec 25 '22 23:12 mbordia-eightfold

Good point. I never noticed that. I think doing a is the ideal solution, seems more efficient. Let me review that PR

julianpacker avatar Feb 27 '23 15:02 julianpacker