wasabi icon indicating copy to clipboard operation
wasabi copied to clipboard

Removing "Loading" text after loading?

Open kallewesterling opened this issue 5 years ago • 7 comments

Hello,

I couldn't find anything in the docs about how to get rid of the "Loading..." text fully after the loading is "finished"? I tried it in a Jupyter Notebook and this is the result:

image

Any suggestions?

kallewesterling avatar May 16 '19 21:05 kallewesterling

Thanks for the report. It seems like in the notebook, the sequence used to erase a line and flush is somehow interpreted differently? Relevant code is here:

https://github.com/ines/wasabi/blob/2beb8fe98cdfe9cafcae0a7c7b18c9738119e337/wasabi/printer.py#L201-L202

I'd need to investigate this. The whole cursor movement stuff, erasing lines etc. is definitiely one of the trickier parts – at least, I've always found it kinda difficult to get right across platforms and configurations and there might still be cases where it fails.

ines avatar May 16 '19 21:05 ines

I know!! I am so happy to have come across your package though! (Found it when I looked over the spaCy code!) I have had so much trouble with flushing... ugh.

kallewesterling avatar May 16 '19 21:05 kallewesterling

I have looked into this issue myself now and cannot find a solution!

kallewesterling avatar May 20 '19 19:05 kallewesterling

@ines do you think the newest release will help with this issue?

kallewesterling avatar Oct 28 '19 16:10 kallewesterling

@kallewesterling any solution ?

ardyfeb avatar Aug 02 '20 17:08 ardyfeb

@ardyfeb I have nothing to do with the dev of this package. Ask @ines! :)

kallewesterling avatar Aug 02 '20 20:08 kallewesterling

@ines Revisited this issue and it now looks like it works better, in a way. At last, the .good() message displays at the end of the loop:

image

However, the context manager does not generate any output in the Notebook. This is what it looks like when inside the with msg.loading() manager:

image

kallewesterling avatar May 14 '21 14:05 kallewesterling