spacy-vscode icon indicating copy to clipboard operation
spacy-vscode copied to clipboard

`pygls > 1.0.x` breaks version checks

Open shadeMe opened this issue 2 years ago • 3 comments
trafficstars

pygls 1.1 seems to have removed the __version__ attribute from the top-level module, which breaks the validation code.

shadeMe avatar Oct 25 '23 13:10 shadeMe

Checking versions for python 3.7+ is annoying due to the lack of importlib.metadata in python 3.7.

If you switch this to python 3.8+ you can use importlib.metadata instead. For python 3.7+ you could use importlib_metadata from spacy.compat. You'd have to refactor the version checking code a bit to import spacy first/separately.

adrianeboyd avatar Nov 07 '23 09:11 adrianeboyd

So a "quick fix" would be to install pygls>=1.0.0,<1.1.0.

But as Python 3.7 and 3.8 have reached their EOL is supporting them in this extension still an issue? If not do you accept pull requests in this repo?

b2m avatar Dec 16 '24 09:12 b2m

Fixed in this pull request

https://github.com/explosion/spacy-vscode/pull/32

igormorgado avatar Mar 08 '25 18:03 igormorgado