spacy-transformers icon indicating copy to clipboard operation
spacy-transformers copied to clipboard

Published 20 hours ago • verified publisher icon explosion

Extend support to transformers v4.39

Open hume-brian opened this issue 1 year ago • 2 comments

Description

Extend support to transformers v4.39.

Types of change

?

Checklist

  • [x] I confirm that I have the right to submit this contribution under the project's MIT license.
  • [x] I ran the tests, and all new and existing tests passed.
  • [x] My changes don't require a change to the documentation, or if they do, I've added all required information.

hume-brian avatar May 20 '24 17:05 hume-brian

Hi @danieldk is there a reason you upper bound the transformers dependency? Our team is using a newer version of transformers and would love to use spacy-transformers!

Maybe spacy-transformers can allow a wider range of transformers versions, perhaps up to a major version change rather than a patch version? Thanks!

gregorybchris avatar May 21 '24 22:05 gregorybchris

transformers updates have broken things in the past. So rather than removing the upper bound, it should be set to some version against which the package is tested.

danieldk avatar May 22 '24 17:05 danieldk