spaCy icon indicating copy to clipboard operation
spaCy copied to clipboard

Replace Pipe with Callable in Language

Open adrianeboyd opened this issue 3 years ago • 3 comments

Description

Replace Pipe with Callable in Language.

Types of change

?

Checklist

  • [x] I confirm that I have the right to submit this contribution under the project's MIT license.
  • [x] I ran the tests, and all new and existing tests passed.
  • [x] My changes don't require a change to the documentation, or if they do, I've added all required information.

adrianeboyd avatar Sep 05 '22 15:09 adrianeboyd

Well, this reminded me why we're using Pipe here. It looks like mypy may support hasattr soon, so I think once that is supported, it would make sense to switch to the correct type Callable instead of Pipe in Language.

adrianeboyd avatar Sep 05 '22 15:09 adrianeboyd

Hey I'd like to help with the docs, or create my own version, how do I proceed. I emailed the developers and it was OK'd. Still a GitHub greenhorn but enjoy technical writing. Thx

robookwus avatar Sep 16 '22 20:09 robookwus

@robookwus: Welcome! This particular thread is for a pull request that's not related to the docs.

Instead, please open a new issue (https://github.com/explosion/spaCy/issues/new?assignees=&labels=&template=02_docs.md) with more details about what you're interested in working on?

adrianeboyd avatar Sep 18 '22 12:09 adrianeboyd

Replaced by #11803.

adrianeboyd avatar Nov 14 '22 14:11 adrianeboyd