PwNixOS icon indicating copy to clipboard operation
PwNixOS copied to clipboard

quality of life

Open NotAShelf opened this issue 10 months ago • 1 comments

Hey! Nice project, but there seems to be a few things that could see some love from the maintainer(s).

  1. The usage of with lib;

Most good nix projects actively avoid with scopes. For better maintainability, those should be replaced with explicit inherits.

  1. Lack of modularity

If this is meant as your personal config, and that only - it's perfectly fine. Otherwise, it will come off as too opinionated and could probably benefit from 1. an internal module system and 2. exposing some of the "pwning" related options as nixosModules that are directly importable from outside.

  1. Confusing structure

Sticking everything in a modules directory is probably a bad idea. Maybe divide things by function so that it's easier to find what you're looking for?

NotAShelf avatar Apr 07 '24 20:04 NotAShelf