ragas icon indicating copy to clipboard operation
ragas copied to clipboard

Fix ensure_ascii for json.dumps

Open ifsheldon opened this issue 1 year ago • 1 comments

Hi! This PR simply fixes all json.dumps. With ensure_ascii=False, unicodes can be properly serialized into JSON files in the modern days when UTF-8 is basically universal. This may also prevent silent behavioral bugs from LLMs, since they can hardly understand literal strings like "\u00x" except common ones.

Some cases do not necessarily need ensure_ascii=False, but they are added for consistency.

ifsheldon avatar Aug 16 '24 09:08 ifsheldon

The PR hasn't been merged, so I can't evaluate it in Korean. I think it's a good PR—are there any reviewers available?

wonseop avatar Sep 11 '24 08:09 wonseop

we did merge another PR for the same and is released with v0.2

closing this for now but I'm really sorry we couldn't merge it 🙁 but at the same time thanks a million for taking the time to raise this, really grateful too and do checkout this form https://docs.google.com/forms/d/e/1FAIpQLSdM9FrrZrnpByG4XxuTbcAB-zn-Z7i_a7CsMkgBVOWQjRJckg/viewform - our way of saying thank you 🙂

jjmachan avatar Nov 03 '24 04:11 jjmachan