Invalid logic in PaypalSubmissionForm

[dunric]

Cartridge ver. > 0.8.4 up to current does not save order in database until last checkout step is executed. PaypalSubmissionForm from cartridge-payments.payments.multipayments.forms ignores this logic and saves session data in its constructor during its instantiation, ie. before payment form is submitted. User can push back-button to update billing/shipping data, but those changes don't get reflected as PaypalSubmissionForm retrieves old data from a database, not current from a session.

A bug ? An intended behavior ?

[joshbatchelor]

Definitely sounds like a bug. If you want to implement a fix, I will review it and merge it in.