bofire icon indicating copy to clipboard operation
bofire copied to clipboard

Feature request doe: build in or offer rounding

Open rosonaeldred opened this issue 2 years ago • 3 comments

https://github.com/experimental-design/bofire/blob/d0f4d76dd08dab256ffa9fe47dbf1e0623c17c66/bofire/strategies/doe/design.py#L25

Because otherwise i get stuff like this, and i expect grumpy users

                x1    x2            x3                    
exp0  8.900000e-01  0.11 -9.978892e-09 
exp1 -9.972607e-09  0.11 -9.977525e-09  
exp2 -9.972607e-09  0.11 -9.977525e-09  
exp3 -9.833874e-09  0.11  6.600000e-01  

rosonaeldred avatar Apr 20 '23 09:04 rosonaeldred

Beware stupid python round behavior that results in such insightful entries as "-0.00" (can fix by applying abs(), but this feels like treating the symptom, not the problem)

rosonaeldred avatar Apr 20 '23 09:04 rosonaeldred

Maybe something for a student?

dlinzner-bcs avatar Apr 24 '23 07:04 dlinzner-bcs

suggestion by @jduerholt smart_round(domain,df)-> df_projected_into_feasible_space, set precision before optimization

dlinzner-bcs avatar Apr 24 '23 07:04 dlinzner-bcs