Ashley

Results 208 comments of Ashley

> I just wanna chip in here and say that what I would love love love is a descriptor-sets-as-structs system This is mentioned here: https://embarkstudios.github.io/rust-gpu/book/rfcs/001-resource-binding-syntax.html but I'm not sure if...

> Sorry for the late reply, I'm just now catching up after the holiday. I ran the test suite before I submitted the pull request, but I've only just realized...

~~I haven't been able to test this with matrices yet as rust-gpu treats the glam `Mat3`s etc. as structs.~~

So I still get validation and perf warning for the specific use case I wanted this for, but I can't do anything about that :P `UNASSIGNED-CoreValidation-Shader-InterfaceTypeMismatch(ERROR / SPEC): msgNum: -1227934722...

Totally forgot about this - I need to check whether it's still needed.

Utgh, I forgot I was on @msiglreith's branch when I tested that 😅 I've been making some progress here: https://github.com/EmbarkStudios/rust-gpu/compare/main...expenses:convert-u-to-ptr it now fails with alignment issues.

> > > Utgh, I forgot I was on @msiglreith's branch when I tested that 😅 > > I've been making some progress here: [main...expenses:convert-u-to-ptr](https://github.com/EmbarkStudios/rust-gpu/compare/main...expenses:convert-u-to-ptr) > > it now fails...

Solved that problem as well - just had to `OpCopyMemory` instructions. https://github.com/EmbarkStudios/rust-gpu/compare/main...expenses:convert-u-to-ptr now works well for my purposes. It'd be good to see how we can get it to a...

https://www.khronos.org/registry/SPIR-V/specs/unified1/SPIRV.html#Addressing_Model > PhysicalStorageBuffer64 > > Indicates that pointers with a storage class of PhysicalStorageBuffer are physical pointer types with an address width of 64 bits, while pointers to all other...

@DJMcNab Right, thanks for investigating! And to clarify, this inlining happens in rust-gpu and not via the `spirv-opt` passes, correct?