Brooklyn Zelenka

Results 224 comments of Brooklyn Zelenka

Yes, dashes or underscores at the beginning or end of names are not valid URLs, and thus fail server validation since it gets used as a subdomain. We should definitely...

> it looks like the code involved doesn't catch the '_' and '@' characters Do you have an example of one with `@`? I'm not able to reproduce that case:...

> If underscores at the end of names are invalid, then we're not checking that both in the server and webnative. Easy enough to fix though :) I misspoke for...

@therealjeffg just following up; are you able to find a case with the `@`? I think we've determined that the `_` is working as expected, unless we want to change...

> Sorry for the delay in getting back to this No worries! > If underscores are valid, we should change this message ti say something like: Agreed β€”Β better message...

@icidasset can you update the Issue description when you have a sec? πŸ™

One option (not necessarily the right one) is only expose a FS handle if the app path is available, and hide all of the above detail. As a quick sketch:...

> Hashes? I thought those would be the inumbers from the spec? Ah I could have been a LOT clearer: hashes of i-numbers in the filter (the set bits) >...

Duplicate of AOL template? cc @bgins / @therealjeffg

https://github.com/fission-suite/webnative-app-template/issues/1