expath-cg icon indicating copy to clipboard operation
expath-cg copied to clipboard

Where are the archive/sandpit files supposed to come from?

Open ndw opened this issue 3 years ago • 5 comments

There are tests in tests/qt3/archive that (seem to) rely on test1.zip and test3.zip existing in the sandpit directory. However, the sandpit directory is not in the repo and is explicitly .gitignored.

Where are they supposed to come from, and what are they supposed to contain?

ndw avatar Apr 06 '22 16:04 ndw

Hi Norm! Good point. I think that either @johnlumley or @michaelhkay would be able to help?

fgeorges avatar Apr 06 '22 20:04 fgeorges

Otherwise, you might be able to reverse-engineer it from tests/qt3/archive/archive.xml (test1.zip must have one entry, new.txt, with content Some text here encoded as UTF-8, etc.) It might get a bit trickier for other properties, like compression, etc.

fgeorges avatar Apr 06 '22 21:04 fgeorges

Hmm. I was going to say that I had some files that seemed to work (I've been tidying up some parts of the Saxonica test harness), but the test1.zip that I have doesn't have a new.txt entry so perhaps I don't yet understand exactly how the tests work.

ndw avatar Apr 07 '22 07:04 ndw

I found some files in a working copy of an old Subversion repository and have done a commit under a new name (sandpit2) but now realise these are probably the same files that Norm found, with no new.txt entry.

michaelhkay avatar Apr 07 '22 08:04 michaelhkay

Don't take my comment about new.txt as the absolute truth, I was just having a quick look at the tests in tests/qt3/archive/archive.xml.

Actually, after a second look, I would rather say that it must be textA.txt and contain "A simple string". The entry new.txt seems to be created by one of the tests themselves (which makes more sense given its name.)

fgeorges avatar Apr 07 '22 12:04 fgeorges