docker-php-fpm icon indicating copy to clipboard operation
docker-php-fpm copied to clipboard

Support arm64 in php 8.1

Open eerison opened this issue 3 years ago • 7 comments

MicrosoftTeams-image (1)

add the support for platform linux/arm64

eerison avatar Nov 01 '22 10:11 eerison

Any comments from @niepi @OskarStark or @llupa on this?

DracoBlue avatar Dec 05 '22 20:12 DracoBlue

It is indeed more specific, but I hadn't any issues in the past and it increases complexity, not sure its worth.

Up to you @DracoBlue

OskarStark avatar Dec 05 '22 21:12 OskarStark

Btw. why is it a draft PR? 🤔

OskarStark avatar Dec 05 '22 21:12 OskarStark

I'm also not in favour on this. The added complexity, is probably not worth it.

niepi avatar Dec 06 '22 08:12 niepi

I started some description at https://github.com/exozet/docker-php-fpm/wiki/Draft-for-new-Structure to figure a new structure for tags etc - not finished, only a draft!

DracoBlue avatar Dec 06 '22 10:12 DracoBlue

I didn't have time to finish 🥲, feel free to continue the pull request.

eerison avatar Dec 06 '22 10:12 eerison

IMO we should build images for arm64 also, the current images are quite slow in M1 processors.

we should do like php image does: Screenshot from 2022-12-06 12-34-30

This action: https://github.com/docker/build-push-action handle multi platform quite easy!

eerison avatar Dec 06 '22 11:12 eerison

@DracoBlue @OskarStark I would be in favour on closing this.

we support arm on https://github.com/Endava/docker-php

niepi avatar Jul 11 '23 10:07 niepi

As it's maintained in other repository, I'm closing this PR ;)

eerison avatar Jul 11 '23 11:07 eerison