exonum-java-binding icon indicating copy to clipboard operation
exonum-java-binding copied to clipboard
verified publisher icon exonum

Switched to concurrent HashMap implementation in the resource-manager [ECR-2934]

Open skletsun opened this issue 6 years ago • 2 comments

Overview

Switched from RwLock<HashMap> to chashmap::CHashMap for the handles storage in the resources manager.

See: https://jira.bf.local/browse/ECR-XYZ

Definition of Done

  • [x] There are no TODOs left in the code
  • [x] Change is covered by automated tests
  • [x] The coding guidelines are followed
  • [x] Public API has Javadoc
  • [x] Method preconditions are checked and documented in the Javadoc of the method
  • [x] Changelog is updated if needed (in case of notable or breaking changes)
  • [ ] The continuous integration build passes

skletsun avatar Feb 21 '19 08:02 skletsun

Coverage Status

Coverage remained the same at 85.53% when pulling 6bbb072bcb6ac5a4c1ae7e5f76fdd4f7b9ec3c89 on skletsun:concurrent-hashmap-resource-manager-ecr-2934 into 89f15e695bee7682e85a9430826611b19cbc1d54 on exonum:master.

coveralls avatar Feb 21 '19 09:02 coveralls

Why don't we also push all these operations in a struct that can be instantiated in both lazy_static and unit tests? Otherwise it is quite hard to test operations on a static shared state.

dmitry-timofeev avatar Feb 21 '19 13:02 dmitry-timofeev