exonum-java-binding icon indicating copy to clipboard operation
exonum-java-binding copied to clipboard

Error-prone compiler enabled. [ECR-1746]

Open DENMROOT opened this issue 7 years ago • 3 comments

Overview

Error-prone compiler enabled. POM files updated. AutoValue auto generated classes fixed.


See: https://jira.bf.local/browse/ECR-1746

Definition of Done

  • [ ] There are no TODOs left in the code
  • [ ] Change is covered by automated tests
  • [ ] The coding guidelines are followed
  • [ ] Public API has Javadoc
  • [ ] Method preconditions are checked and documented in the Javadoc of the method
  • [ ] Changelog is updated if needed (in case of notable or breaking changes)
  • [ ] The continuous integration build passes

DENMROOT avatar Nov 01 '18 12:11 DENMROOT

Please update LICENSES-THIRD-PARTY.TXT

bullet-tooth avatar Nov 03 '18 22:11 bullet-tooth

@bullet-tooth Error Prone is licensed under Apache license https://github.com/google/error-prone/blob/master/COPYING we already have it in LICENSES-THIRD-PARTY.TXT

DENMROOT avatar Nov 05 '18 10:11 DENMROOT

@DENMROOT yes, it is. But there is a list of third parties governed under Apache 2.0 that should be extended with the new component

bullet-tooth avatar Nov 05 '18 13:11 bullet-tooth