exonum-java-binding icon indicating copy to clipboard operation
exonum-java-binding copied to clipboard

Add an interface for Transaction error code: [ECR-2006]

Open dmitry-timofeev opened this issue 6 years ago • 1 comments

Overview

That's a quick prototype I decided to try when updating the documentation section on transaction exceptions: exonum/exonum-doc@9ce5998f553249897b0d7d3d8d5aae12bc20400e

Whilst it might appear as some extra work, it makes it easier to use an enum for the error codes instead of just a bunch of constants, which has some extra useful properties (like free #toString implementation).


See: https://jira.bf.local/browse/ECR-XYZ

Definition of Done

  • [ ] There are no TODOs left in the code
  • [ ] Change is covered by automated tests
  • [ ] The coding guidelines are followed
  • [ ] Public API has Javadoc
  • [ ] Method preconditions are checked and documented in the Javadoc of the method
  • [ ] Changelog is updated if needed (in case of notable or breaking changes)
  • [ ] The continuous integration build passes

dmitry-timofeev avatar Dec 06 '19 13:12 dmitry-timofeev

Coverage Status

Coverage decreased (-0.05%) to 85.895% when pulling 5d7b8073807ed03991cc8559c69292c221024175 on dmitry-timofeev:add-interface-for-error-code into 4a8fabb8e22f7aa483d823447335657e4c172fd2 on exonum:master.

coveralls avatar Dec 06 '19 14:12 coveralls