Merlijn Visser

Results 22 comments of Merlijn Visser
trafficstars

I'm indifferent on this. I prefer a quirk-free feature set, but I also understand the desire to not have too many ways to achieve the same thing.

Hadn't thought of the builtin functions; in that case, I definitely think this should be allowed yeah.

My idea was to change the error message (in 1.9) to `"Missing required parameter for function '%s'"` and then using `current_user_function_name` as the argument. That is trivial and much more...

Oh, I just realised the issue with using `current_user_function_name` as I suggested: it gets changed when calling a function, not when exiting one, so it wouldn't work with function calls...

Ah, that wasn't obvious to me from the manual. Still, it seems intuitive to me to assume that any identifier would support namespacing, not just some subset of them, so...

I just thought of an interesting unhandled edge-case: what if there's an `org` or `base` statement between the `datasize`'d label and the next? Or, perhaps more simply/relevantly put, what if...

The message "datasize exceeds 0xFFFF" isn't exactly accurate or helpful in the negative case though.

Tangential note: for both Asar 1.91 and 2.0, `bra` and the simple conditional branches write the opcode and branch offset _before_ checking the offset's correctness, and the bit check conditional...

> [does #ifdef count as portable?](https://github.com/Alcaro/Arlib/blob/master/arlib/file-exepath.cpp?rgh-link-date=2024-08-09T21%3A52%3A30Z) Note that, for the Windows implementation, the path may not fit in `MAX_PATH`-length buffer when long path support is enabled. Also, I'm not sure...

I wasn't aware DLLs have inconsistent path reporting through `GetModuleFileName`.