exo icon indicating copy to clipboard operation
exo copied to clipboard

Fix #73 - Calcs now correctly the TFLOPS for MacBook Pro M1 Max

Open stephanj opened this issue 1 year ago • 7 comments

stephanj avatar Jul 24 '24 20:07 stephanj

Awesome work! Thanks so much for the PR.

Could you also update the tests in exo/topology/test_device_capabilities.py @stephanj

AlexCheema avatar Jul 24 '24 21:07 AlexCheema

Looks good on my MacBook Pro :)

image

stephanj avatar Jul 26 '24 14:07 stephanj

Looks like you might've accidentally committed your .idea :)

AlexCheema avatar Jul 27 '24 05:07 AlexCheema

Please also remove output.json from VC

AlexCheema avatar Jul 27 '24 05:07 AlexCheema

Update mac_device_capabilities tests for JSON parsing and mocking

  • Refactor tests to use JSON-based system_profiler output
  • Add mocked test for MacBook Pro with M3 Max chip
  • Improve robustness of chip detection in mac_device_capabilities function
  • Update assertions to match new JSON parsing logic

image

stephanj avatar Jul 27 '24 07:07 stephanj

Needs some more work because now I'm getting again 0 TFLOPS... hold on

stephanj avatar Jul 27 '24 07:07 stephanj

Should be good now! image image

stephanj avatar Jul 27 '24 08:07 stephanj

Lot of configuration files were committed here. Closing as these values were updated since this PR and we are moving to dynamic FLOPS calculation with #297.

AlexCheema avatar Nov 23 '24 19:11 AlexCheema