exo icon indicating copy to clipboard operation
exo copied to clipboard

grpc_peer_handle for serializing inference state using wrong numpy type

Open risingsunomi opened this issue 11 months ago • 2 comments

Currently, there is a function that detects if running Apple based systems or not. It then sets an mx variable that points to either mlx or numpy depending on your system.

This causes issues when adding more than one node to the network and passing the inference state.

https://github.com/exo-explore/exo/blob/main/exo/networking/grpc/grpc_peer_handle.py#L203

Current fix suggestion is by adding a boolean IS_APPLE to check and later assigning a variable mx_array_type the proper type

https://github.com/risingsunomi/exo-pt/blob/grpc-fix-jan242025/exo/networking/grpc/grpc_peer_handle.py#L17-L22

https://github.com/risingsunomi/exo-pt/blob/grpc-fix-jan242025/exo/networking/grpc/grpc_peer_handle.py#L206-L211

My fork has too many changes to do a pull request.

Thank you and appreciate all your work on this.

risingsunomi avatar Jan 24 '25 22:01 risingsunomi

My fork has too many changes to do a pull request.

Can you create a new fork and cherry-pick the specific changes you suggest onto that fork?

silibattlebot avatar Jan 29 '25 03:01 silibattlebot

My fork has too many changes to do a pull request.

Can you create a new fork and cherry-pick the specific changes you suggest onto that fork?

Will do, just didn't want to create too many forks. Will make a dedicated one for main exo issues.

risingsunomi avatar Jan 29 '25 22:01 risingsunomi