DCNC icon indicating copy to clipboard operation
DCNC copied to clipboard

Published 20 hours ago • verified publisher icon exmex

Username case mismatch

Open exmex opened this issue 6 years ago • 0 comments

I'm submitting a ...

  • bug report

What is the current behavior? [REQUIRED]

  • If username in DB is lower-case but user used upper case to log-in, the server rejects his first packet due to ticket mismatch.

Steps to reproduce [REQUIRED]

  1. Create user with lower-case (eg. helloworld)
  2. Login with upper-case (eg. Helloworld)

What is the expected behavior? [REQUIRED]

User should be able to check-in since his packet was valid.

Other informations [OPTIONAL]

We could fix this by lower-casing both usernames in the check here: https://github.com/exmex/DCNC/blob/7821c133d62d8ab28580004ef1e2d8b4ec08cffc/src/LobbyServer/Network/Handlers/UserInfo.cs#L17

Log

[Error] - Rejecting packet from 0.0.0.0:51539 (user: helloworld vs Helloworld, ti
cket 3311448694 vs 3311448694) for invalid user-ticket combination.
[Info] - Killing off client.

exmex avatar Jan 22 '18 12:01 exmex