mdlr icon indicating copy to clipboard operation
mdlr copied to clipboard

Releases for windows

Open BarbzYHOOL opened this issue 7 years ago • 5 comments

Sorry to spam @svarlamov

You should put the release files for windows in the release section of github!

BarbzYHOOL avatar Oct 17 '18 22:10 BarbzYHOOL

No problem... I should do that for all of it, but not too familiar with the Github releases setup as we'd have to also add the binaries in addition the source code at the release tag... Is this something that you'd like to contribute to? Would be much appreciated and then we can deprecate the S3-based downloads

svarlamov avatar Oct 18 '18 04:10 svarlamov

I never did it either nor used git tags yet :( but you're not forced to make it a hassle, I suppose you just need to upload the binary when you decide to, so basically just upload the actual binaries to github and next time when there is something really major updated

Why? because it's one of the thing people look for when they don't want to compile the src (I myself look if there is any release)

Look, I made a test in 10 seconds lol https://github.com/BarbzYHOOL/fish-msg/releases/tag/1

BarbzYHOOL avatar Oct 18 '18 17:10 BarbzYHOOL

I'm also quite worried about it being on amazon and not github

Even for the linux installer @svarlamov

BarbzYHOOL avatar Oct 21 '18 17:10 BarbzYHOOL

Fixed here https://github.com/exlinc/mdlr/commit/f7a91810eee6e7dc7967aeda571539de2713b44b ? it gonna be easier to automatically install!

  • now we can watch for new releases on github

BarbzYHOOL avatar Nov 30 '18 21:11 BarbzYHOOL

So I just checked this and it seems there's an issue following the GitHub S3 redirect to download the files (as GH hosts everything on their S3 anyways). I'll need to look into that prior to updating the readme

svarlamov avatar Dec 01 '18 01:12 svarlamov