zig icon indicating copy to clipboard operation
zig copied to clipboard

Zig TDD Exercises

Open otherJL0 opened this issue 1 year ago • 3 comments

As discussed in this post, this PR

  • adds a small skipTest() function wrapping the SkipTestError error and
  • adds a call to skipTest() to the top of each test

otherJL0 avatar Mar 09 '23 14:03 otherJL0

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

github-actions[bot] avatar Mar 09 '23 14:03 github-actions[bot]

Thanks :) I've reopened it. There's some internal discussion about this (and skips in general) so it might take be next week until it gets reviewed :)

iHiD avatar Mar 10 '23 01:03 iHiD

I'm setting this as draft while we discuss, to signal to maintainers that this must not be merged as-is.

Before merging, we'd need to at least:

  1. Alter bin/run-tests so that it removes the skips. At the time of writing, this PR means that CI only tests the first test case for each exercise.
  2. Make the Zig test runner remove the test skips, so that all tests run when using the online editor.
  3. Add skips to exercises that were added after this PR was opened.

I suggest that we don't begin working on any of the above quite yet.

ee7 avatar Mar 12 '23 12:03 ee7