website-copy icon indicating copy to clipboard operation
website-copy copied to clipboard

codeowners: is this file actually considerd by github to assign reviewers?

Open NobbZ opened this issue 4 years ago • 7 comments

Today I had to manually assign reviewers to a PR, so I checked if that entry is missing in the CODEOWNERS file. Its not. Therefore I checked more PRs:

  • #1248, manually assigned reviewers by me, this is the PR mentioned in the abstract above.
  • #1188, only individual reviews, no review request to exercism/website-copy-rust as far as I can tell from the issue log, one of the individual reviewers is a member of that team though.
  • #1215, a single individual reviewed, but no review request was made according to the logs, that individual is a member of the appropriate team though.
  • #1217, same as #1215

I'm not sure now if #1248 was just a hickup of GitHub not having assigned the team, and the other 3 were properly assigned but assignment not visible in the logs, or if none of the PRs was actually correctly assigned for review.

Perhaps someone can provide more datapoints, as I'm out of time for now.

NobbZ avatar Aug 20 '19 07:08 NobbZ