ruby
ruby copied to clipboard
exercism
[V3] Use consistent naming for method references
Looking at the existing Ruby exercises, there are a couple of different ways methods are referred to. I've seen:
'Please implement the pass? method'- 'Please implement the LogLineParser.log_level method'
- 'Please implement the Lasagna#remaining_minutes_in_oven method'
There are several places where methods are being referred to, but most notably they are referred to in the instructions.md files and the stub implementation files (and occasionally the hints.md files). It would be nice to use a uniform way of referring to methods.
I'm fairly sure that @iHiD wants to use <CLASS>.<METHOD> for class methods, and <CLASS>#<METHOD> for instance methods. So I'd suggest normalizing to those.
I'm fairly sure that @iHiD wants to use <CLASS>.<METHOD> for class methods, and <CLASS>#<METHOD> for instance methods. So I'd suggest normalizing to those.
Correct. Thanks, @ErikSchierboom!
Quick question on the Log Line Parser exercise. The instructions don't seem to reference the class methods which is different to the instructions of the other exercises. E.g.
# current
Implement a method to return a log line's log level, which should be returned in lowercase:
# expected
Implement the `LogLineParser.log_level` method to return a log line's log level, which should be returned in lowercase:
Should I make this change, or just leave it as is?
Quick question on the Log Line Parser exercise. The instructions don't seem to reference the class methods which is different to the instructions of the other exercises. E.g.
# current Implement a method to return a log line's log level, which should be returned in lowercase: # expected Implement the `LogLineParser.log_level` method to return a log line's log level, which should be returned in lowercase:Should I make this change, or just leave it as is?
I wonder if this is because the concepts being taught are different, perhaps the difference between class and instance method is assumed to be known at this point?
I have to read the documentation tomorrow of the entire structure and get up to speed with what is here.
Should I make this change, or just leave it as is?
Please make this change. This is a mistake in the existing exercise.
