python icon indicating copy to clipboard operation
python copied to clipboard

[Clock] Review Test Cases and Discuss Structure and Objectives of Exercise

Open BethanyG opened this issue 3 years ago • 1 comments

Filing this as a tracking issue and invitation to a discussion on revisions to this exercise.

The intent of Clock was to practice class customization and operator overloading via dunder methods in Python. We've recently had quite a few changes, adding __repr__ to the mix, as well as additional instructions and tests in support of that change. A few issues have now come up around it:

  1. Issue #2926
  2. Issue #3008

It feels like this exercise is overloaded. It especially has too many tests, and is perhaps not clear enough in its directions and hints as to what the student does or does not need to think about for their implementations.

Thoughts on rework/adjustment clarification strategies welcome here.

BethanyG avatar Apr 17 '22 18:04 BethanyG

🤖   🤖

Hi! 👋🏽 👋 Welcome to the Exercism Python Repo!

Thank you for opening an issue! 🐍  🌈 ✨


  •   If you are requesting support, we will be along shortly to help. (generally within 72 hours, often more quickly).
  •   Found a problem with tests, exercises or something else??  🎉
      ◦ We'll take a look as soon as we can & identify what work is needed to fix it. (generally within 72 hours).

​          ◦ If you'd also like to make a PR to fix the issue, please have a quick look at the Pull Requests doc.
             We  💙  PRs that follow our Exercism & Track contributing guidelines!

  •   Here because of an obvious (and small set of) spelling, grammar, or punctuation issues with one exercise,
      concept, or Python document?? 🌟 Please feel free to submit a PR, linking to this issue. 🎉
    ‼️  Please Do Not ‼️

    ​        ❗ Run checks on the whole repo & submit a bunch of PRs.
                  This creates longer review cycles & exhausts reviewers energy & time.
                  It may also conflict with ongoing changes from other contributors.
    ​        ❗ Insert only blank lines, make a closing bracket drop to the next line, change a word
                  to a synonym without obvious reason, or add trailing space that's not an EOL for the very end of text files.         ❗ Introduce arbitrary changes "just to change things" .

            ...These sorts of things are not considered helpful, and will likely be closed by reviewers.

  • For anything complicated or ambiguous, let's discuss things -- we will likely welcome a PR from you.
  • Here to suggest a feature or new exercise?? Hooray! Please keep in mind Chesterton's Fence.
    Thoughtful suggestions will likely result faster & more enthusiastic responses from maintainers.

💛  💙  While you are here... If you decide to help out with other open issues, you have our gratitude 🙌 🙌🏽.
Anything tagged with [help wanted] and without [Claimed] is up for grabs.
Comment on the issue and we will reserve it for you. 🌈 ✨

github-actions[bot] avatar Apr 17 '22 18:04 github-actions[bot]