python icon indicating copy to clipboard operation
python copied to clipboard

[React]: Add /Review Test Template and Review and Test Exercise

Open cmccandless opened this issue 5 years ago • 3 comments

Task

Create a test template file for react

Details

  1. If this is your first time contributing to this repository, welcome!
    • Contributing to a repository on GitHub requires a fork
  2. Create a branch on your local repository called react-add-test-template
    • Run: git checkout -b react-add-test-template
  3. Clone problem-specifications repository; this is used to populate the template
    • Run: git clone https://github.com/exercism/problem-specifications ../problem-specifications
  4. Create exercises/react/.meta/template.j2
  5. Generate test file from new template
    • Run: bin/generate_tests.py react

At this point, if the generator fails, or you are otherwise stuck, please feel free to reach out! It is perfectly acceptable to submit an incomplete PR in order to get feedback or assistance.

Resources

cmccandless avatar Oct 02 '19 14:10 cmccandless

Hey, I would like to try this issue too :D

beatorizu avatar Oct 20 '19 03:10 beatorizu

@beatorizu have fun with it, we welcome a PR.

yawpitch avatar Oct 20 '19 11:10 yawpitch

Noting here: 90% of this work has been completed in PR #2096. However, there has been a lot of changes since that PR was submitted, so the exercise, the specifications, and the generated tests need to be reviewed to make sure everything would still work with the template. Leaving this issue open as a reminder that the review work needs to be completed, and at if all possible, we should resurrect the PR and get it to a state where it can be merged and used.

BethanyG avatar Apr 19 '22 19:04 BethanyG

Closing this as the work was reviewed, adjusted and submitted.

BethanyG avatar Feb 25 '23 08:02 BethanyG