problem-specifications icon indicating copy to clipboard operation
problem-specifications copied to clipboard

Tree Builder: Exercise requires sorting of results, but this is not mentioned in the description

Open dirkkul opened this issue 2 years ago • 0 comments

Hi, I was send here after creating a MR in the go repository.

Currently the tests of the tree builder exercise assume an order of a node's children, however the description does not specify anything about the order.

Example: Build for test case "three nodes in order" returned 0:[2:[] 1:[]] but was expected to return 0:[1:[] 2:[]].

I think this could be solved in two ways:

  • Adding the requirement of sorting the results to the description
  • Make the tests agnostic to the order (for example by sorting actual and expected nodes in the tests before comparing them). However (afaik) this would require adapting the tests in each track, eg what I've done in the linked MR for go.

I'm happy to expand the description if this is the preferred solution, just let me know.

dirkkul avatar May 13 '22 09:05 dirkkul