php
php copied to clipboard
Add State of Tic-Tac-Toe Exercise
Todo:
- [x] Add Enum when we have PHP 8.1 as min requirement
The current solution using strings as the result is according to specification.
But I think, this is the perfect exercise to use an
enum
as a return type. That would mean, a) changing the implementation and b) pause the merging, until we have PHP8.1 as minimum version.I would be very happy, if you agree to wait for that. When we merge this now, we cannot change the interface later to use
enum
as that invalidates all submitted solutions.What do you think?
I'm perfectly fine with enum
and waiting. I think enum
makes perfectly sense in this case.
Edit: Just for information, I have added this thread to the Forum https://forum.exercism.org/t/php-versions-support/10070
It's expected to fail in PHP 8.0 as I have already added the enum
we talked about yesterday. Then we might just need to rebase when we are ready to merge.
That's looks great! Looking forward to having a minimum of PHP 8.1...
@tomasnorre Today the PHP track got upgraded to the required PHP version. You may rebase this branch and update the PR.
I must have done something wrong in the rebasing. As all the changes are included.
I did
- Sync my fork
- git checkout branch
- git rebase main
- git push --force
Update: Looks better now. I did the sync of my fork incorrect.