ocaml icon indicating copy to clipboard operation
ocaml copied to clipboard

Broken test-generation for exercise phone-number

Open georgyo opened this issue 1 year ago • 0 comments

This exercise has been marked as having a broken test generator. There are a lots of reasons for test generation to break for a given exercise including

  • New addition of new tests that example.ml does not handle correctly. All that is required here is to fix or replace the example!
  • Changes to the problem-specification's canonical-data.json that our test-gen cannot handle. This could be then additional of field names, changing field names, or addition of tests that not fit with Ocaml's way of doing things. The task here is figure out what changed in the problem-specification and fix or add rules to special_cases.ml.

Useful links

GitHub doesn't allow for linking the diff of an individual file making the relevant canonical-data.json diff impossible to link to. It may be easier to run this in your terminal

git submodule update --init
git -C problem-specifications diff 2af3c9b0074f16c62366c5c533eaacd3ff27b583 -- exercises/phone-number/canonical-data.json

Check List

  • [ ] Delete templates/phone-number/.broken
  • [ ] Fix test-generation
  • [ ] Test the test generation with make phone-number.gentest

georgyo avatar Mar 11 '23 17:03 georgyo