lfe icon indicating copy to clipboard operation
lfe copied to clipboard

Upgrade to LFE 2.2.0

Open BNAndras opened this issue 11 months ago • 1 comments

See https://github.com/exercism/lfe-test-runner/pull/68. This repo's CI uses the test runner image, but that makes it a bit difficult to prep upgrading the repo. I'll open a separate PR about moving the CI off the test runner image.

BNAndras avatar Mar 20 '25 05:03 BNAndras

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

github-actions[bot] avatar Mar 20 '25 05:03 github-actions[bot]

FYI, this will rerun 3.3k solutions track-wide.

BNAndras avatar Jun 07 '25 04:06 BNAndras

FYI, this will rerun 3.3k solutions track-wide.

Does it really need to? The ones that are submitted now and written for the prior version has passed, is there any reason to have them potentially fail? If not, please do make the commit comment to avoid that.

kotp avatar Jun 07 '25 05:06 kotp

If we don’t rerun the solutions, do they get the invalidator files upgraded automatically or not?

BNAndras avatar Jun 07 '25 05:06 BNAndras

Invalidator when changed marks a solution as out of date. So the student would need to update which at that point runs the solution through the test runner with the updated files. Therefore I should be able to do [no important files changed] here.

BNAndras avatar Jun 07 '25 05:06 BNAndras