julia icon indicating copy to clipboard operation
julia copied to clipboard

rotational-cipher: Instructions are missing the bonus tasks

Open SaschaMann opened this issue 3 years ago • 1 comments

See https://github.com/exercism/configlet for docs on how to fix this.

SaschaMann avatar Oct 25 '21 15:10 SaschaMann

I believe the bonus task tests aren't being run because the isdefined check

# Bonus A
if isdefined(Main, Symbol("@R13_str"))
    @eval @testset "Bonus A: string literal R13" begin

always returns false. This is because user's code gets evaluated in the module

@__MODULE__() = ExercismTestReports

instead of Main, as revealed by @show @__MODULE__.

So the fix is:

# Bonus A
if isdefined(ExercismTestReports, Symbol("@R13_str")) # user code is evaluated in ExercismTestReports module
    @eval @testset "Bonus A: string literal R13" begin

Jollywatt avatar Oct 25 '21 21:10 Jollywatt

@SaschaMann I guess this issue should be closed.

kerolloz avatar Oct 11 '22 20:10 kerolloz