javascript icon indicating copy to clipboard operation
javascript copied to clipboard

[v3] Add prerequisites 3/6

Open TomPradat opened this issue 4 years ago • 12 comments

⚠️ If you have issues / are unsure, create ONE PR PER EXERCISE so it's easier to merge them as we can have discussions per exercise. If you're certain, it's fine to do a single one.

The idea is to split #960 into smaller chunks.

Here is the list of practices exercises to deal with for this part :

anagram

acronym

high-scores

isogram

matching-brackets

phone-number

scale-generator

series

largest-series-product

transpose

grep

rectangles

spiral-matrix

ocr-numbers

saddle-points

forth

food-chain

house

isbn-verifier

pig-latin

TomPradat avatar Feb 15 '21 17:02 TomPradat

I am willing to take this issue up (at least some of the exercises). Just let me know if I should make the PRs, one for each exercises, one for a batch of exercises or one for all of them.

AnishDe12020 avatar Dec 02 '21 14:12 AnishDe12020

I'd suggest that you make a PR for each exercise but if you feel like you want to do a lot of exercises you can take 4-5 by PR.

Trying to do all of them at once is not a good idea IMO, it's indigestible for both you and the reviewer.

Idk if this might help but here are the steps I used when doing some :

1 - Doing/trying the exercise 2 - Looking at the exercise's proof of work 3 - Looking at the submitted solutions. 4 - Adding the prerequisites

TomPradat avatar Dec 02 '21 14:12 TomPradat

Good advice from @TomPradat there. I am in favor of a batch of max. 5 exercises per PR.

junedev avatar Dec 02 '21 15:12 junedev

I'd suggest that you make a PR for each exercise but if you feel like you want to do a lot of exercises you can take 4-5 by PR.

Trying to do all of them at once is not a good idea IMO, it's indigestible for both you and the reviewer.

Idk if this might help but here are the steps I used when doing some :

1 - Doing/trying the exercise 2 - Looking at the exercise's proof of work 3 - Looking at the submitted solutions. 4 - Adding the prerequisites

Sounds good to me

AnishDe12020 avatar Dec 02 '21 15:12 AnishDe12020

Here is an updated list (25/10/2022) :

  • ~matching-brackets~

  • scale-generator

  • ~series~

  • largest-series-product

  • transpose

  • ~grep~

  • rectangles

  • ~spiral-matrix~

  • ocr-numbers

  • saddle-points

  • forth

  • food-chain

  • house

  • isbn-verifier

  • pig-latin

TomPradat avatar Oct 25 '22 18:10 TomPradat

Is this still open? Would love to work on it if it is!

safwansamsudeen avatar Apr 14 '23 07:04 safwansamsudeen

@safwansamsudeen Yes ! See https://github.com/exercism/javascript/issues/984#issuecomment-984682274 for suggestions on how to do it. Let me know if you have any questions

TomPradat avatar Apr 14 '23 07:04 TomPradat

@safwansamsudeen If you work on this, please start out with a small batch, e.g. 3 exercises max. Add a GitHub comment for each one explaining which solution you had in mind when selecting the concepts you listed. Maybe paste a link to a community solution or paste some code. This is the only way the PR becomes reviewable. Without this, the reviewer needs to do the exact work you did to come up with the list again to verify it makes sense.

junedev avatar Apr 15 '23 20:04 junedev

@TomPradat Please keep this in mind https://exercism.org/blog/freeing-our-maintainers and that neither JD not me are currently actively maintaining this repo. Only encourage community contributions if you are confident that you have the time to properly review them when they come in. Otherwise it will be a frustrating experience for everyone.

junedev avatar Apr 15 '23 20:04 junedev

@junedev I'm new to both OSS and Exercism, so I think I'll start off with one exercise per PR.

@TomPradat, I've currently opened a PR - #2159 - for the House exercise. Let me know how it goes!

safwansamsudeen avatar Apr 29 '23 04:04 safwansamsudeen

@safwansamsudeen I'll have a look next week when I have a bit more time 👍

TomPradat avatar May 10 '23 15:05 TomPradat

@TomPradat, just a reminder about the PR.

safwansamsudeen avatar May 31 '23 10:05 safwansamsudeen