javascript icon indicating copy to clipboard operation
javascript copied to clipboard

Added filles for the new rest and spread exericse

Open meatball133 opened this issue 2 years ago • 7 comments

Resolve #1500

This is the start for the exercise. There is still some stuff that I haven't started on like hints and design.

It is because I think they require that the rest is more or less finished.

meatball133 avatar Nov 11 '22 18:11 meatball133

Dear meatball133

Thank you for contributing to the JavaScript track on Exercism! 💙 You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • 📜 The following files usually contain very similar content.

    • concepts/<concept>/about.md
    • concepts/<concept>/introduction.md
    • exercises/concept/<exercise>/.docs/introduction.md

    Please check whether the changes you made to one of these also need to be applied to the others.

  • 🧦 If you changed the function signature or the JSDoc comment in the exemplar file (.meta/exemplar.js) or the stub file (<exercise>.js), make sure the change is applied to both files.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

github-actions[bot] avatar Nov 11 '22 18:11 github-actions[bot]

I feel like I have resolved the issues mentioned above. If not please tell me and I will give it another round

meatball133 avatar Nov 15 '22 18:11 meatball133

I feel like I have resolved the issues mentioned above. If not please tell me and I will give it another round

Thank you for the work!

We'll check it out.

SleeplessByte avatar Nov 15 '22 18:11 SleeplessByte

Could some one go through with me why errors are raised? The changes I made should not have caused this.

meatball133 avatar Nov 20 '22 13:11 meatball133

Could some one go through with me why errors are raised? The changes I made should not have caused this.

Sorry I didn't see this. Seems you managed to solve this yourself!

For future contributions, on this track repository you can post a comment with / followed by format and it will format it on the PR directly.

SleeplessByte avatar Jan 01 '23 21:01 SleeplessByte

I see, no problem. But thanks for the tip.

I made some commits to some other tracks, so I learnt there how the config file needs to be setup.

meatball133 avatar Jan 01 '23 21:01 meatball133

I see, no problem. But thanks for the tip.

I made some commits to some other tracks, so I learnt there how the config file needs to be setup.

I'll pick up the reviewing here :)

SleeplessByte avatar Jun 09 '23 14:06 SleeplessByte