javascript icon indicating copy to clipboard operation
javascript copied to clipboard

adding prerequisites to roman numerals, binary, hexadecimal, octal, s…

Open meganriley opened this issue 3 years ago • 6 comments

…quare-root, trinary, all-your-base, minesweeper, queen-attach, react, and zipper (not darts)

meganriley avatar Sep 29 '22 03:09 meganriley

Dear meganriley

Thank you for contributing to the JavaScript track on Exercism! 💙 You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

github-actions[bot] avatar Sep 29 '22 03:09 github-actions[bot]

/format

SleeplessByte avatar Oct 02 '22 16:10 SleeplessByte

Closing and re-opening to trigger CI

SleeplessByte avatar Oct 02 '22 16:10 SleeplessByte

The failing CI is not your doing. It's because that tool has updated and now is complaining about a new (previously non-existent) rule.

SleeplessByte avatar Oct 02 '22 16:10 SleeplessByte

@SleeplessByte Is it safe to rename those topic names? Will it break anything for in-progress or completed exercises on the live site?

tejasbubane avatar Oct 03 '22 21:10 tejasbubane

Safe to rename. Only occurrences should be in the repo itself. If we have a same named folder in concepts (not excercises, just the concepts folder) those should be renamed too but that's it.

SleeplessByte avatar Oct 04 '22 01:10 SleeplessByte