javascript icon indicating copy to clipboard operation
javascript copied to clipboard

Fruit Picker: Improve story/instructions

Open junedev opened this issue 2 years ago • 12 comments

Follow up from https://github.com/exercism/javascript/pull/1725#discussion_r895047045

Some tasks in the fruit picker exercise are currently rather "technical" instead of being phrased in terms of the overall story. Maybe someone has a good idea who to improve this.

https://github.com/exercism/javascript/blob/main/exercises/concept/fruit-picker/.docs/instructions.md

General documentation: https://exercism.org/docs/building/tracks/concept-exercises#h-file-docs-instructions-md

junedev avatar Jun 29 '22 20:06 junedev

I already did the fruit picker exercise. now I see in Github that the exercise gets updated. So, I go to update my code but my boilerplate didn't change according to the new test cases. so, how I'll solve that question?

Aliwahid17 avatar Jul 02 '22 16:07 Aliwahid17

@Aliwahid17 In this case you need to open the exercise (so you see the page with the web editor), click on the 3 dots in the top right corner and select "revert to exercise start". Then you get the fresh boilerplate. I'm sorry for the inconvenience here but a lot of the new learning exercises are still in "beta" and need to be changed substantially to make the experience better for the users. So this issue can happen every now and then.

The original issue here was about something else. In the future it would be great if you can open a new issue instead of re-purposing an existing one. That makes it easier for maintainers. Thanks in advance. I will hide these comments later on so they don't confuse others that look at this issue.

junedev avatar Jul 02 '22 19:07 junedev

Oh ok I'm new in GitHub so i don't know that . Thanks for telling me i know next time.

Aliwahid17 avatar Jul 03 '22 00:07 Aliwahid17

Hi @junedev 👋🏽

I'd be happy to take on this issue if that's alright?

I've been going through the exercises within the Go track and I can see how the instructions on the JS track may come off as "technical"...

ex. " Create a callback to be called when the order is successful` Write a callback function called onSuccess to be called when the order is successful. It should invoke the imported notify function passing a success message to it.

An alternative could be...

1.Let the user know the order is successful

Define the onSuccess() function that will be called when the order is successful. This function will pass { message: 'SUCCESS' } to the notify() function which indicates that the order completed successfully.

@junedev , Is this more more inline with what you imagine to be less "technical" and more in tune with the story?

Additionally in the Instructions prompt I imagine there could be additional elaboration on the tasks to be completed and some additional backstory to the fruit-picking? I look at annalyns-infiltration as an example where there is some story and a setting of expectations of what the tasks to complete will be.

mannyistyping avatar Aug 13 '22 23:08 mannyistyping

@mannyistypingonacomputer Sounds like you have a good understanding of what the task is here. 🙂 I will assign you to the issue.

junedev avatar Aug 14 '22 04:08 junedev

Thank you for the quick response @junedev and sounds good! 👍🏽

mannyistyping avatar Aug 14 '22 04:08 mannyistyping

@junedev is this issue still open? I can see instructions.md hasn't been updated since April 2022. Happy to pick this one up if it still needs working on.

alexmitchelldev avatar Jun 19 '23 20:06 alexmitchelldev

@junedev is this issue still open? I can see instructions.md hasn't been updated since April 2022. Happy to pick this one up if it still needs working on.

Hey there, Alex!

Feel free to pick up. I've gotten sidetracked with personal issues.

mannyistyping avatar Jun 19 '23 20:06 mannyistyping

Thank you Manny!

I would love to, if you don't mind.

alexmitchelldev avatar Jun 19 '23 20:06 alexmitchelldev

I don't mind at all. I don't believe I'm able to reassign so when @junedev or another member has a moment to reassign then 🙂👍

Thank you for moving this forward.

mannyistyping avatar Jun 19 '23 20:06 mannyistyping

Re-assigned!

SleeplessByte avatar Jun 22 '23 09:06 SleeplessByte

@SleeplessByte could you take a look at the above PR I submitted please? Also, I noticed #1833 is still open. I'd be happy to look at this as well, please assign to me if you'd like me to 😄.

alexmitchelldev avatar Jun 28 '23 17:06 alexmitchelldev