javascript icon indicating copy to clipboard operation
javascript copied to clipboard

Dates Concept Exercise (Library Fees)

Open JaPrad opened this issue 3 years ago • 8 comments

@junedev, I just wanted to ensure with you if the story in .docs/instructions.md file is okay. If it is, I will move forward writing the spec, test and other docs files

JaPrad avatar May 27 '22 10:05 JaPrad

Dear JaPatGitHub

Thank you for contributing to the JavaScript track on Exercism! 💙 You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • 🧦 If you changed the function signature or the JSDoc comment in the exemplar file (.meta/exemplar.js) or the stub file (<exercise>.js), make sure the change is applied to both files.

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

github-actions[bot] avatar May 27 '22 10:05 github-actions[bot]

@junedev , @SleeplessByte just a reminder

JaPrad avatar Jun 09 '22 06:06 JaPrad

@JaPatGitHub Sorry for the delay, we were both busy. I have time again in the coming days. I will respond to your question as soon as possible.

junedev avatar Jun 09 '22 20:06 junedev

@JaPatGitHub Great work on the story/tasks! With the last task I am not sure whether it will add anything really related to handling dates in the end. If not, maybe you can combine 4 and 5 into one task where the students needs to check for Monday and calculate the late fee so the story has a nice ending.

One more general comment regarding the instructions: After the header for an individual task and the story sentence, there should be a sentence that is very clear on what function to write and what inputs and outputs it has. See https://github.com/exercism/javascript/blob/eedba9962c36ef22a86ab04733845fe2481653b9/exercises/concept/bird-watcher/.docs/instructions.md?plain=1#L17 for an example of what I mean. This is also described in the docs for concept exercises: https://exercism.org/docs/building/tracks/concept-exercises#h-file-docs-instructions-md

junedev avatar Jun 29 '22 15:06 junedev

@JaPatGitHub Are you still working on this?

SleeplessByte avatar Aug 23 '22 00:08 SleeplessByte

I'm sorry @SleeplessByte , I didn't notice @junedev 's reply in my last PR which I was waiting for. I'll start working on it right away.

JaPrad avatar Aug 25 '22 13:08 JaPrad

@junedev , should I close this PR? Or do I just make the modifications you previously suggested so that who works next on this can use this story...

JaPrad avatar Sep 11 '22 01:09 JaPrad

@JaPatGitHub yes, let's not throwaway your hard work and author credit. If you could make those suggestions that'd be great. If not, that's also okay, then we stash it somewhere so the next person can continue.

SleeplessByte avatar Sep 11 '22 12:09 SleeplessByte