Add practice exercise markdown

[0xBradock]

trafficstars

closes #918

[github-actions[bot]]

Dear Kmelow

Thank you for contributing to the JavaScript track on Exercism! 💙 You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

• ⬆️ The instructions and test cases for many practice exercises originate in the Exercism-wide problem-specifications repo. If the exercise you changed is listed there in the exercises folder, please consider the following.

  • Improvements to the instructions.md file should be made in the problem-spec repo so that all tracks can benefit. You can open a PR there instead.
  • If you want to add some language specific information, use the instructions.append.md file (see Practice Exercise Docs).
  • Test cases selected in the .meta/tests.toml file need to be implemented in the <exercise>.spec.js file according to the specification in canonical-data.json.

• ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

• 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

• 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

• 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

• 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

_{Automated comment created by PR Commenter 🤖.}

[0xBradock]

Hello,

Can I get feedback on the approach used for the file to refactor markdown.js? Any suggestions for improvement?

Thanks,

[junedev]

@Kmelow I am sorry, I cannot really help you with that. I don't have experiences with this exercise in other languages and with the Exercism refactoring exercises in general. I can only recommend looking at the stub files (that should be refactored) used in other languages (e.g. C#, python, Go) to get some inspiration. Maybe @SleeplessByte has some feedback on your approach to markdown.js. If not, I would recommend you just proceed as you see fit and we will see how the exercise is perceived later on.

[SleeplessByte]

Hi there!

Thanks for the work thusfar. I don't see anything particular that's really wrong, albeit this solution is likely going to fail quite a bit of markdown. That said, I won't be able to give you in-depth feedback until late next week. If you absolutely want that, feel free to wait on it, or, as @junedev suggest, keep on going.

Thanks for your time investment!

[0xBradock]

I can only recommend looking at the stub files (that should be refactored) used in other languages (e.g. C#, python, Go) to get some inspiration.

So, that's what I set out to do. I checked some PHP and python. I realized that there is a good amount of if statements and some regexp.

[0xBradock]

I don't see anything particular that's really wrong, albeit this solution is likely going to fail quite a bit of markdown.

I don't think I got that, can you elaborate, please.

If you absolutely want that, feel free to wait on it, or, as @junedev suggest, keep on going.

I'm planning to work more on it this weekend, so any input would be much appreciated. Thanks

[SleeplessByte]

I think you're also on our Exercism Slack right? If you just want to hit me up tomorrow, given that I'm in Europe/Amsterdam and you seem to be from/in France, a quick sync-chat or call would work for me. I'm crunching a deadline until Tuesday, but I don't want you to get stuck, so I can make some time tomorrow or sunday to talk with your through this if you want.

[0xBradock]

I think you're also on our Exercism Slack right?

Hum... don't think I got the invitation

If you just want to hit me up tomorrow, given that I'm in Europe/Amsterdam and you seem to be from/in France, a quick sync-chat or call would work for me. I'm crunching a deadline until Tuesday, but I don't want you to get stuck, so I can make some time tomorrow or sunday to talk with your through this if you want.

It's all right, I'll do some other things and we can chat later during the week