java icon indicating copy to clipboard operation
java copied to clipboard

Secret Handshake exercise should have `Signal` class/enum visible/editable

Open artamonovkirill opened this issue 2 years ago • 2 comments

More context: https://exercism-team.slack.com/archives/CATD6MX62/p1661262277270479

For the online editor, it's not clear that the enum is already defined, so students might attempt to redefine it inside HandshakeCalculator. That causes deceiving compilation errors.

artamonovkirill avatar Aug 24 '22 19:08 artamonovkirill

Thanks for pointing this out.

The fix here is to add a files.editor key in exercises/practice/secret-handshake/.meta/config.json containing that extra file - this will make the editor aware of that file and show it in reading mode.

andrerfcsantos avatar Sep 25 '22 13:09 andrerfcsantos

https://github.com/exercism/java/pull/2191 @andrerfcsantos is there any way I can test this change before merging?

artamonovkirill avatar Oct 28 '22 12:10 artamonovkirill

@artamonovkirill Unfortunately, no. I left a comment on the PR.

Thanks for doing this. I noticed this is a problem in a lot of other exercises too - they have extra files but are not declared in either the files.solution or files.editor key (#2170). I've meaning to write a little script to fix instances where this happens, but haven't find the time yet. In the meantime, feel free to create PRs about this for the exercises you are solving.

andrerfcsantos avatar Oct 29 '22 14:10 andrerfcsantos

It appears for me now 🎉

image

andrerfcsantos avatar Oct 29 '22 19:10 andrerfcsantos

@artamonovkirill Unfortunately, no. I left a comment on the PR.

Thanks for doing this. I noticed this is a problem in a lot of other exercises too - they have extra files but are not declared in either the files.solution or files.editor key (#2170). I've meaning to write a little script to fix instances where this happens, but haven't find the time yet. In the meantime, feel free to create PRs about this for the exercises you are solving.

@andrerfcsantos I wrote the script to check exercise files and added missing files: https://github.com/exercism/java/pull/2195 😁

artamonovkirill avatar Nov 05 '22 16:11 artamonovkirill