haskell icon indicating copy to clipboard operation
haskell copied to clipboard

added two tests for deep setRight and setLeft

Open atombear opened this issue 2 years ago • 8 comments

atombear avatar Oct 14 '22 17:10 atombear

I suspect a patch to problem-specifications/zipper would be welcome as well.

MatthijsBlom avatar Oct 14 '22 17:10 MatthijsBlom

@MatthijsBlom sorry, what do you mean? is there anything else i should do for this pr? someone needs to kick the ci for me...

atombear avatar Oct 28 '22 16:10 atombear

What it means is to submit a pull request to https://github.com/exercism/problem-specifications/blob/main/exercises/zipper/canonical-data.json

petertseng avatar Oct 28 '22 16:10 petertseng

To elaborate: the tests are generated/derived from the problem specifications in the problem-specifications repo. This is done to make it easier to collectively maintain exercises among the many individual language tracks. I have repeatedly seen it suggested to send PR's to problem-specifications first/instead, hence my suggestion to approach them.

MatthijsBlom avatar Oct 28 '22 17:10 MatthijsBlom

@MatthijsBlom @petertseng how do i make the pr? ie, i can make a pr directly to that file, but it would seem at least that i need to supply a uuid? how do i derive that value?

atombear avatar Oct 31 '22 16:10 atombear

I really don't know, but I'm sure the maintainers of the problem-specifications repo will tell you.

MatthijsBlom avatar Oct 31 '22 16:10 MatthijsBlom

It is your choice how you generate the UUID, as long as it is a version 4 UUID.

petertseng avatar Oct 31 '22 17:10 petertseng

Oh, silly me, of course it doesn't matter how it is generated: it is unique, after all!

MatthijsBlom avatar Oct 31 '22 17:10 MatthijsBlom