go icon indicating copy to clipboard operation
go copied to clipboard

Remove unused 'input' field

Open Caesarovich opened this issue 11 months ago • 4 comments

The input field is unused and causes a linter warning, which might be confusing for someone doing this exercise.

Screenshot from 2024-03-06 18-24-03

Caesarovich avatar Mar 06 '24 17:03 Caesarovich

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

github-actions[bot] avatar Mar 06 '24 17:03 github-actions[bot]

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

github-actions[bot] avatar Mar 06 '24 17:03 github-actions[bot]

Hi, thanks for replying.

I did not notice this .meta folder at first, my bad. I am not quite sure to understand yet how it works, please let me know if my latest commit contains errors.

Caesarovich avatar Mar 12 '24 06:03 Caesarovich

Any follow up @andrerfcsantos ?

Caesarovich avatar May 18 '24 09:05 Caesarovich

Closing and reopening to force CI to run.

andrerfcsantos avatar Jul 24 '24 23:07 andrerfcsantos

@Caesarovich I don't like to mess with other people's branches, but in the interest of merging this, I merged main from upstream into your branch. I also made an extra commit fixing a formatting warning in gen.go.

Thanks for this!

andrerfcsantos avatar Jul 24 '24 23:07 andrerfcsantos