go
go copied to clipboard
Issue 2475 roman numerals max 3999
Adjust Instructions and Unit Tests to support maximum Roman numeral 3999 Issue https://github.com/exercism/go/issues/2475
Adjustment to problem specification, instructions, and unit tests to support the max val 3,999 which can be expressed in Roman numerals (without getting into the "Larger number" scenarios)
Dear dbh
Thank you for contributing to the Go track on Exercism! 💙 You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.
-
⬆️ The instructions and test cases for many practice exercises originate in the Exercism-wide problem-specifications repo. If the exercise you changed is listed there in the exercises folder, please consider the following.
- Improvements to the
instructions.md
file should be made in the problem-spec repo so that all tracks can benefit. You can open a PR there instead. - If you want to add some language specific information, use the
instructions.append.md
file (see Practice Exercise Docs). - Test cases selected in the
.meta/tests.toml
file need to be implemented in the<exercise>_test.go
file according to the specification incanonical-data.json
.
- Improvements to the
-
🔗 If your PR fully fixes an issue, please include the text
Fixes #issue_no
in any line of the PR description. This will make the issue be automatically be closed when the PR is merged. If your PR is related to an existing issue but does not fix it completely, please link the issue anywhere in the description of the PR with#issue_no
. You can read more about this in Github: Linking a pull request to an issue -
✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.
-
🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found
Unicdoe
, use "replace all" in your editor (or command line magic) to fix it consistently.
Dear Reviewer/Maintainer
-
📏 Make sure you set the appropriate
x:rep
label for the PR. (This also works after merging, in case you forgot about it.) -
🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.
-
🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?
Automated comment created by PR Commenter 🤖.
@junedev @IsaacG Would you kindly review? This is the Go-Lang exercise follow up for the recently approved Problem Spec clarification for Roman numerals. I ran configlet to sync the problem spec instructions and test cases into the toml
Thanks!
Go-Lang issue https://github.com/exercism/go/issues/2475
Problem Spec (merged/closed) PR https://github.com/exercism/problem-specifications/pull/2094 Issue https://github.com/exercism/problem-specifications/issues/2095
@junedev Thanks for pointing out the necessary changes in the example solution in .meta folder