go
go copied to clipboard
exercism
roman-numerals: Adjust Instructions and Unit Tests to support maximum Roman numeral 3999
See issue 2095 in the problem-specifications repo since this issue not only affects go, but also the problem spec used by other languages.
The Roman numeral problem description now states:
There is no need to be able to convert numbers larger than about 3000. (The Romans themselves didn't tend to go any higher)
That's a little confusing if we're looking at the definition of Roman numerals and assuming the full range would be supported.
I propose altering the Instructions to state that the maximum Roman numeral which can be expressed has the value of 3999 (to match definition of Roman numerals). Unit tests will be modified to include through 3999 as valid and 4000 as an invalid. Happy to contribute the PR.
PRs to address:
Previous background/history:
