go
go copied to clipboard
Added Additional Hint for Processing Parts of a Date
Hint for time.Parse
alone is not helpful. Even minor changes can render the time incorrect. This could be frustrating for learners.
Dear saurami
Thank you for contributing to the Go track on Exercism! π You will see some automated feedback below π€. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.
-
π If your PR fully fixes an issue, please include the text
Fixes #issue_no
in any line of the PR description. This will make the issue be automatically be closed when the PR is merged. If your PR is related to an existing issue but does not fix it completely, please link the issue anywhere in the description of the PR with#issue_no
. You can read more about this in Github: Linking a pull request to an issue -
βοΈ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.
-
π€ If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found
Unicdoe
, use "replace all" in your editor (or command line magic) to fix it consistently.
Dear Reviewer/Maintainer
-
π Make sure you set the appropriate
x:rep
label for the PR. (This also works after merging, in case you forgot about it.) -
π Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.
-
π€ After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?
Automated comment created by PR Commenter π€.
The link that AndrΓ© provided at the top contains exactly the information you saw in the source code, you only need to scroll down a bit (after the code block). It is generated from the source code that is why the information is the same. Please change the PR to use the link suggested above instead of a link to the source code. Copying some parts is not necessary. Learning to read the official docs is a good thing as part of the learning process on Exercism.
Official docs for the time package constants contains a lot more info than whats asked in the exercise. Even minor formatting changes will produce a completely different time output. That's why I think relevant sections from the official documentation should be a part of the instruction.
I have updated the link, but don't think it is a good idea.
Learning to read the official docs is a good thing, but it would be appropriate to expect learners to go through the official docs in the next iteration of a learning exercise based on time.
Ideally, the introduction for a learning exercise contains enough information that no one has to look up any external resource. Currently, the introduction for the time exercise is not very good and we have a separate issue about fixing this. The hint is not meant to give a good introduction about the topic. It is only meant for someone that needs additional resources to understand what to do. That's why I think it is good as is.