fsharp icon indicating copy to clipboard operation
fsharp copied to clipboard

Booking up for beauty example solution invalid

Open vaeng opened this issue 2 years ago • 4 comments

It seems like the implementation for the AM PM string representation has changed. The current proof solution from the repository does not work with the current test.

The current F# implementation does not use a space any longer between the time and the AM/PM.

https://github.com/exercism/fsharp/blob/930ca1cf056961485f7d03cafe0ebff52984a091/exercises/concept/booking-up-for-beauty/BookingUpForBeautyTests.fs#L161

vaeng avatar Feb 27 '24 13:02 vaeng

You can pass a date format into the ToString method of DateTime.

Screenshot 2024-04-11 at 10 13 16 PM

KyleDickersonComposer avatar Apr 12 '24 02:04 KyleDickersonComposer

There is something weird going on, as the tests have .Replace('\u202F', ' ') appended to them, but they still don't work. Whereas adding .Replace('\u202F', ' ') to the implementation works. I'll have a dig.

ErikSchierboom avatar Apr 17 '24 10:04 ErikSchierboom

I've just upgraded to the latest version of the exercise and now the tests do pass. Could you check that works for you @vaeng?

ErikSchierboom avatar Apr 24 '24 10:04 ErikSchierboom

Sweet. Looks like you've solved the exercise!

@ErikSchierboom Seems to work as intended! 🥳

vaeng avatar Apr 24 '24 10:04 vaeng