emacs-lisp icon indicating copy to clipboard operation
emacs-lisp copied to clipboard

Verify that tests actually implement the canonical tests

Open fapdash opened this issue 3 years ago • 3 comments

It seems that some of the tests don't implement the tests that they claim to implement in their meta/tests.toml, see https://github.com/exercism/emacs-lisp/pull/228. Also some exercises don't implement all canonical tests according to the toml. Find out which ones with configlet sync --tests or configlet sync --tests -e testname We should go through all the exercises and verify.

  • [ ] crypto-square
  • [ ] etl
  • [ ] phone-number
  • [ ] word-count
  • [x] acronym #350
  • [x] allergies #351
  • [x] anagram #352
  • [x] armstrong-numbers #353
  • [X] binary N/A (deprecated)
  • [x] bob #385
  • [x] difference-of-squares N/A (good as-is)
  • [x] gigasecond #367
  • [x] grains N/A (good as-is)
  • [x] hamming #368
  • [x] hello-world N/A (good as-is)
  • [x] leap #228
  • [x] luhn #384
  • [x] nucleotide-count #357
  • [x] pangram #358
  • [x] perfect-numbers N/A (good as-is)
  • [x] raindrops #354
  • [x] rna-transcription N/A (good as-is)
  • [x] robot-name N/A (no canonical tests)
  • [x] roman-numerals #356
  • [x] run-length-encoding N/A (good as-is)
  • [x] trinary N/A (deprecated)
  • [x] two-fer N/A (good as-is)

fapdash avatar Oct 18 '22 21:10 fapdash

I would suggest the acronym tests be updated to include something with punctuation, such as the example from the readme: "Thank George It's Friday". Some of the community ones that passed would not pass this, which is not helpful for those learning from them.

mkleehammer avatar Jun 10 '23 05:06 mkleehammer

I would suggest the acronym tests be updated to include something with punctuation, such as the example from the readme: "Thank George It's Friday". Some of the community ones that passed would not pass this, which is not helpful for those learning from them.

There's a canonical test for Hailey's Comet that would take care of this once synced. I can take a look later this week.

BNAndras avatar Apr 21 '24 22:04 BNAndras

Atbash Cipher is missing the decoding half of the exercise so I'm separating that off into a separate issue for tracking.

BNAndras avatar May 13 '24 01:05 BNAndras