elm icon indicating copy to clipboard operation
elm copied to clipboard

Add analyzer issues for concepts where we can't check concept usage with tests

Open mpizenberg opened this issue 4 years ago • 5 comments

mpizenberg avatar Jul 25 '21 08:07 mpizenberg

Could elm-review help with that? like write a special rule that require to use a certain things (e.g. use case ... of instead of if then else if then else ... )

leojpod avatar Sep 17 '21 16:09 leojpod

elm-review could definitely help with analyzers! I haven't explored that space yet though and never written a rule yet either. But if you think of something for existing exercises don't hesitate to ask around in the elm-review channel of the slack.

mpizenberg avatar Sep 17 '21 16:09 mpizenberg

One thing for sure, is that we can't blindly apply elm-review rules on all exercises. Especially in concept exercises where some concepts might not be introduced yet, or push the code in a direction that may not be the most idiomatic one (that's also a sign that a concept exercise is not designed too well but we do how we can ^^)

mpizenberg avatar Sep 17 '21 16:09 mpizenberg

I was more thinking of rules designed explicitly for one exercise, not of rules to apply to all exercises. I don't have much time to play with it right now but I'll keep it in mind :)

leojpod avatar Sep 17 '21 17:09 leojpod

I have opened issues for all the concept exercises. Hopefully that can be part of the workflow when adding new ones.

I have added some ideas of mine when design.md did not specify anything, so please feel free to push back or add some ideas of your own.

jiegillet avatar Feb 03 '22 14:02 jiegillet