elixir
elixir copied to clipboard
Add more tests to `say`
I had few cases where all tests passed but some numbers I tried were not correct.
It was a while ago, so I do not remember clearly, but it was between 20 and 1000.
Thank you for contributing to exercism/elixir
💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.
Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:
-
General steps
- 🏆 Does this PR need to receive a label with a reputation modifier (
x:size/{tiny,small,medium,large,massive}
)? (A medium reputation amount is awarded by default, see docs)
- 🏆 Does this PR need to receive a label with a reputation modifier (
-
Any exercise changed
- 👤 Does the author of the PR need to be added as an author or contributor in
<exercise>/.meta/config.json
(see docs)? - 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
- 📜 Does the design file (
<exercise>/.meta/design.md
) need to be updated to document new implementation decisions?
- 👤 Does the author of the PR need to be added as an author or contributor in
-
Practice exercise changed
- 🌲 Do
prerequisites
,practices
, anddifficulty
inconfig.json
need to be updated? - 🧑🏫 Are the changes in accordance with the community-wide problem specifiations?
- 🌲 Do
-
Practice exercise tests changed
- ⚪️ Are all tests except the first one skipped?
- 📜 Does
<exercise>/.meta/tests.toml
need updating?
Automated comment created by PR Commenter 🤖.
Thank you for the contribution. The usual way to add tests is through the problem-specifications repo, where exercises and tests are defined for all tracks. Maybe you can try opening a PR over there?
I have created a PR in the problem-specifications repository with the 4 new tests.
PR related to this ticket in the problem-specifications has been accepted.
Your PR in problem specifications has been merged, you will need to also:
- update the
tests.toml
config - add yourself as a contributor to this practice exercise in the
.meta/config.json
.
tests.toml
and .meta/config.json
have been updated.