elixir icon indicating copy to clipboard operation
elixir copied to clipboard

Add more tests to `say`

Open aifrak opened this issue 2 years ago • 3 comments

I had few cases where all tests passed but some numbers I tried were not correct.

It was a while ago, so I do not remember clearly, but it was between 20 and 1000.

aifrak avatar Aug 09 '22 16:08 aifrak

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?
  • Practice exercise tests changed

    • ⚪️ Are all tests except the first one skipped?
    • 📜 Does <exercise>/.meta/tests.toml need updating?

Automated comment created by PR Commenter 🤖.

github-actions[bot] avatar Aug 09 '22 16:08 github-actions[bot]

Thank you for the contribution. The usual way to add tests is through the problem-specifications repo, where exercises and tests are defined for all tracks. Maybe you can try opening a PR over there?

jiegillet avatar Aug 14 '22 04:08 jiegillet

I have created a PR in the problem-specifications repository with the 4 new tests.

aifrak avatar Aug 14 '22 07:08 aifrak

PR related to this ticket in the problem-specifications has been accepted.

aifrak avatar Oct 02 '22 18:10 aifrak

Your PR in problem specifications has been merged, you will need to also:

  • update the tests.toml config
  • add yourself as a contributor to this practice exercise in the .meta/config.json.

neenjaw avatar Oct 02 '22 19:10 neenjaw

tests.toml and .meta/config.json have been updated.

aifrak avatar Oct 04 '22 08:10 aifrak