dart icon indicating copy to clipboard operation
dart copied to clipboard

Update scripts based on recent configlet changes

Open devkabiir opened this issue 4 years ago • 8 comments

I noticed in the recent PR #295, that our check_formatting is running configlet lint manually, which is no longer required since #283 added a separate workflow for it.

The following scripts need to be updated:

configlet fmt is not supported at the moment. Maybe later

Originally posted by @ErikSchierboom in https://github.com/exercism/dart/issues/301#issuecomment-781383216

devkabiir avatar Feb 17 '21 14:02 devkabiir

@devkabiir I'm going to start looking into this ticket.

Stargator avatar Jul 25 '21 00:07 Stargator

@devkabiir It does seem like #301 resolves this issue. Is there something else related to this?

Stargator avatar Oct 16 '21 02:10 Stargator

I think the presubmit script hasn't been updated.

devkabiir avatar Oct 16 '21 05:10 devkabiir

@devkabiir Okay, I'll address that in my branch. Thanks

But it looks like configlet still doesn't have a format option, so that part will likely have to wait

Stargator avatar Oct 16 '21 19:10 Stargator

But it looks like configlet still doesn't have a format option, so that part will likely have to wait

That is correct. We don't yet have that, but we will at some point :)

ErikSchierboom avatar Oct 19 '21 09:10 ErikSchierboom

@ErikSchierboom Has configlet been updated to format the config files?

Stargator avatar Oct 30 '22 18:10 Stargator

@Stargator configlet formats exercise config files, but does not yet format the track-level config file.

kytrinyx avatar Oct 30 '22 18:10 kytrinyx

@devkabiir Updated the original post to track the other scripts that need to be updated.

Stargator avatar Oct 30 '22 18:10 Stargator