dart
dart copied to clipboard
Update scripts based on recent configlet changes
I noticed in the recent PR #295, that our check_formatting
is running configlet lint
manually, which is no longer required since #283 added a separate workflow for it.
The following scripts need to be updated:
-
~~
check_formatting
~~ -
- Will likely be replaced by a new generator used for all tracks with an plugin/extension for the dart track.
-
presubmit
also needs an update.
configlet fmt
is not supported at the moment. Maybe later
Originally posted by @ErikSchierboom in https://github.com/exercism/dart/issues/301#issuecomment-781383216
@devkabiir I'm going to start looking into this ticket.
@devkabiir It does seem like #301 resolves this issue. Is there something else related to this?
I think the presubmit script hasn't been updated.
@devkabiir Okay, I'll address that in my branch. Thanks
But it looks like configlet still doesn't have a format option, so that part will likely have to wait
But it looks like configlet still doesn't have a format option, so that part will likely have to wait
That is correct. We don't yet have that, but we will at some point :)
@ErikSchierboom Has configlet been updated to format the config files?
@Stargator configlet formats exercise config files, but does not yet format the track-level config file.
@devkabiir Updated the original post to track the other scripts that need to be updated.