configlet
configlet copied to clipboard
consider improving some TOCTOU subtleties
For example, if a user:
- Runs
configlet sync -u --tests -e foo - Waits at the prompt
- Changes the
tests.tomlfile for exercisefooin their track directory, e.g. addinginclude = falseto a test. - Continues going through configlet prompts until completion
If I recall correctly, configlet sync still works, and ignores that the file was changed. We could document this, or consider producing a warning if the file was modified since read-time. But it's probably tricky (and not worth trying) to support arbitrary changes to a file that we're asking questions about.
- TOCTOU
- Tme Of Check to Time Of Use
But it's probably tricky (and not worth trying) to support arbitrary changes to a file that we're asking questions about.
I'd happily not consider this edge case at all. If people are running configlet to update files, and then start editing those files whilst doing that, I don't think we need to detect that in order to provide "sane" behavior.